Skip to content

DAOS-18921 tests: avoid MS broken during CR test#18182

Open
Nasf-Fan wants to merge 1 commit intorelease/2.6from
Nasf-Fan/DAOS-18921_b26
Open

DAOS-18921 tests: avoid MS broken during CR test#18182
Nasf-Fan wants to merge 1 commit intorelease/2.6from
Nasf-Fan/DAOS-18921_b26

Conversation

@Nasf-Fan
Copy link
Copy Markdown
Contributor

@Nasf-Fan Nasf-Fan commented May 6, 2026

During CR tests, some rank maybe excluded intentionally. Set enough MS replicas in the configuration file to avoid MS broken during the eviction related CR test cases.

Test-tag: test_daos_cat_recov_core
Skip-nlt: true
Skip-unit-tests: true
Skip-fault-injection-test: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@Nasf-Fan
DAOS-18921 tests: avoid MS broken durig CR test
1241566 
During CR tests, some rank maybe excluded intentionally. Set enough
MS replicas in the configuration file to avoid MS broken during the
eviction related CR test cases.

Test-tag: test_daos_cat_recov_core
Skip-nlt: true
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Fan Yong <fan.yong@hpe.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026 •
edited
Loading

Ticket title is 'recovery/cat_recov_core.py:CatRecovCoreTest.test_daos_cat_recov_core - CR29 dmg_pool_create failed, rc: -1025'
Status is 'In Review'
Labels: '2.6.5rc1,daily_test,triaged'
https://daosio.atlassian.net/browse/DAOS-18921

@Nasf-Fan Nasf-Fan marked this pull request as ready for review May 6, 2026 13:22
@Nasf-Fan Nasf-Fan requested review from a team as code owners May 6, 2026 13:22
@Nasf-Fan Nasf-Fan requested a review from kjacque May 6, 2026 13:22
@Nasf-Fan Nasf-Fan changed the title DAOS-18921 tests: avoid MS broken durig CR test DAOS-18921 tests: avoid MS broken during CR test May 6, 2026
@Nasf-Fan Nasf-Fan requested review from a team and gnailzenh May 6, 2026 13:24
@daltonbohning
Copy link
Copy Markdown
Contributor

daltonbohning commented May 6, 2026

This is what we do already for other daos_test, but shouldn't the default svcn already be at least 3 when we have enough nodes for it? Out of scope for this PR, but maybe we should not default to 1 in the test suite

daos/src/tests/suite/daos_test_common.c

Line 24 in ed111d4

unsigned int svc_nreplicas = 1;

kjacque
kjacque approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kjacque kjacque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine as long as there are enough nodes set up for the test. Is there a way to verify that in the daos_test code?

@Nasf-Fan
Copy link
Copy Markdown
Contributor Author

Nasf-Fan commented May 7, 2026

Should be fine as long as there are enough nodes set up for the test. Is there a way to verify that in the daos_test code?

There are other configurations in the yaml file that specifies the servers and engines for the test:

hosts:
  test_servers: 4
...
  engines:
    0:
      targets: 4
...
    1:
      targets: 4

@Nasf-Fan
Copy link
Copy Markdown
Contributor Author

Nasf-Fan commented May 7, 2026 •
edited
Loading

This is what we do already for other daos_test, but shouldn't the default svcn already be at least 3 when we have enough nodes for it? Out of scope for this PR, but maybe we should not default to 1 in the test suite

daos/src/tests/suite/daos_test_common.c

Line 24 in ed111d4

unsigned int svc_nreplicas = 1;

I am not quite sure for that. Such changes may affect developers to directly test related C logic (instead of via python interface) locally with small cluster. To be consistent with other tests, explicitly specifying the required replicas maybe more safe.

@Nasf-Fan Nasf-Fan requested a review from a team May 7, 2026 01:52
@Nasf-Fan
Copy link
Copy Markdown
Contributor Author

Nasf-Fan commented May 7, 2026

Passed all required tests.

@daltonbohning daltonbohning added forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. waiting-for-merge-approval Waiting for merge approval labels May 7, 2026
@daltonbohning
Copy link
Copy Markdown
Contributor

daltonbohning commented May 7, 2026

The ticket does not have merge approval

@daltonbohning daltonbohning removed the request for review from a team May 7, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@kjacque kjacque kjacque approved these changes

@gnailzenh gnailzenh Awaiting requested review from gnailzenh

Assignees

No one assigned

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. waiting-for-merge-approval Waiting for merge approval

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nasf-Fan @daltonbohning @kjacque